Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some minor fixes #235

Merged
merged 9 commits into from
Nov 9, 2023
Merged

Some minor fixes #235

merged 9 commits into from
Nov 9, 2023

Conversation

CGNonofr
Copy link
Contributor

@CGNonofr CGNonofr commented Nov 9, 2023 •
edited
Loading

fix #232

@CGNonofr CGNonofr requested a review from kaisalmen November 9, 2023 10:47
@CGNonofr CGNonofr mentioned this pull request Nov 9, 2023
Closed
@CGNonofr CGNonofr force-pushed the other-various-fixes branch from 5285cc7 to 6608ef8 Compare November 9, 2023 11:23
kaisalmen
kaisalmen previously approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. LGTM.

@CGNonofr
Copy link
Contributor Author

CGNonofr commented Nov 9, 2023

@kaisalmen oops forgot to remove unused imports 4237237

@CGNonofr
Copy link
Contributor Author

CGNonofr commented Nov 9, 2023

The theme being used immediately is pretty nice, don't know why I didn't investigate it sooner...

@kaisalmen
Copy link
Collaborator

The theme being used immediately is pretty nice, don't know why I didn't investigate it sooner...

I do it like that order everywhere, so there is some improvement work ahead 🙈

@CGNonofr
Copy link
Contributor Author

CGNonofr commented Nov 9, 2023

@kaisalmen can you reapprove?

@kaisalmen
Copy link
Collaborator

Are you aware of this problem in the demo?
image

@CGNonofr
Copy link
Contributor Author

CGNonofr commented Nov 9, 2023

There is not enough context for me to understand what's happening, how do you produce that error?

@kaisalmen
Copy link
Collaborator

Just by loading the page

@CGNonofr
Copy link
Contributor Author

CGNonofr commented Nov 9, 2023

Just by loading the page

Oh ok, it has no consequence, didn't open the console... I'm having a look

@kaisalmen
Copy link
Collaborator

It's the snippet service during initialization

@kaisalmen
Copy link
Collaborator

Sorry for the delay... Had lunch break and rebuild everything to be sure it's not a stupid caching problem

@CGNonofr CGNonofr mentioned this pull request Nov 9, 2023
Merged
@CGNonofr CGNonofr force-pushed the other-various-fixes branch from 4237237 to 404bf87 Compare November 9, 2023 13:57
@CGNonofr
Copy link
Contributor Author

CGNonofr commented Nov 9, 2023

@kaisalmen ef9dc48 + 404bf87

@kaisalmen
Copy link
Collaborator

kaisalmen commented Nov 9, 2023 •
edited
Loading

@CGNonofr doing a full rebuild now and will let you know once I have results

kaisalmen
kaisalmen previously approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now properly. 🎉 LGTM

brianjenkins94
brianjenkins94 reviewed Nov 9, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@CGNonofr CGNonofr force-pushed the other-various-fixes branch from 404bf87 to 1721136 Compare November 9, 2023 14:42
@CGNonofr CGNonofr force-pushed the other-various-fixes branch from 1721136 to 959f7db Compare November 9, 2023 14:44
kaisalmen
kaisalmen approved these changes Nov 9, 2023
View reviewed changes
Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!

@CGNonofr CGNonofr merged commit 0da94f1 into main Nov 9, 2023
1 check passed
@CGNonofr CGNonofr deleted the other-various-fixes branch November 9, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianjenkins94 brianjenkins94 brianjenkins94 left review comments

@kaisalmen kaisalmen kaisalmen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

registerExtension does not appear to return anything called registerFile
3 participants
@CGNonofr @kaisalmen @brianjenkins94